From 0456eccca89d198df99fb2e73e9add9b4d4b70a5 Mon Sep 17 00:00:00 2001 From: Gustavo Jose de Sousa Date: Tue, 11 Aug 2015 16:28:43 +1000 Subject: [PATCH] AP_HAL: standardize inclusion of libaries headers This commit changes the way libraries headers are included in source files: - If the header is in the same directory the source belongs to, so the notation '#include ""' is used with the path relative to the directory containing the source. - If the header is outside the directory containing the source, then we use the notation '#include <>' with the path relative to libraries folder. Some of the advantages of such approach: - Only one search path for libraries headers. - OSs like Windows may have a better lookup time. --- libraries/AP_HAL/Scheduler.h | 2 +- libraries/AP_HAL/Semaphores.h | 2 +- libraries/AP_HAL/UARTDriver.cpp | 2 +- libraries/AP_HAL/Util.cpp | 2 +- libraries/AP_HAL/Util.h | 2 +- .../AP_HAL/examples/AnalogIn/AnalogIn.cpp | 22 +++--- libraries/AP_HAL/examples/Printf/Printf.cpp | 64 ++++++++--------- libraries/AP_HAL/examples/RCInput/RCInput.cpp | 66 +++++++++--------- .../RCInputToRCOutput/RCInputToRCOutput.cpp | 66 +++++++++--------- .../AP_HAL/examples/RCOutput/RCOutput.cpp | 66 +++++++++--------- libraries/AP_HAL/examples/Storage/Storage.cpp | 68 +++++++++---------- .../AP_HAL/examples/UART_test/UART_test.cpp | 66 +++++++++--------- libraries/AP_HAL/utility/BetterStream.h | 2 +- libraries/AP_HAL/utility/Print.cpp | 2 +- libraries/AP_HAL/utility/Socket.cpp | 2 +- libraries/AP_HAL/utility/Socket.h | 2 +- libraries/AP_HAL/utility/ftoa_engine.cpp | 4 +- libraries/AP_HAL/utility/ftoa_engine.h | 2 +- libraries/AP_HAL/utility/print_vprintf.cpp | 4 +- libraries/AP_HAL/utility/print_vprintf.h | 2 +- 20 files changed, 224 insertions(+), 224 deletions(-) diff --git a/libraries/AP_HAL/Scheduler.h b/libraries/AP_HAL/Scheduler.h index e9833780e7..ea4cc68f91 100644 --- a/libraries/AP_HAL/Scheduler.h +++ b/libraries/AP_HAL/Scheduler.h @@ -6,7 +6,7 @@ #include "AP_HAL_Boards.h" #include -#include +#include class AP_HAL::Scheduler { public: diff --git a/libraries/AP_HAL/Semaphores.h b/libraries/AP_HAL/Semaphores.h index b8ce982a4f..6dfa3d0c13 100644 --- a/libraries/AP_HAL/Semaphores.h +++ b/libraries/AP_HAL/Semaphores.h @@ -2,7 +2,7 @@ #ifndef __AP_HAL_SEMAPHORES_H__ #define __AP_HAL_SEMAPHORES_H__ -#include +#include "AP_HAL_Namespace.h" #define HAL_SEMAPHORE_BLOCK_FOREVER ((uint32_t) 0xFFFFFFFF) diff --git a/libraries/AP_HAL/UARTDriver.cpp b/libraries/AP_HAL/UARTDriver.cpp index d121d56284..95a4c53366 100644 --- a/libraries/AP_HAL/UARTDriver.cpp +++ b/libraries/AP_HAL/UARTDriver.cpp @@ -14,7 +14,7 @@ along with this program. If not, see . */ -#include +#include "AP_HAL.h" #include "utility/print_vprintf.h" #include "UARTDriver.h" diff --git a/libraries/AP_HAL/Util.cpp b/libraries/AP_HAL/Util.cpp index b0d49bb119..71bd14d2a8 100644 --- a/libraries/AP_HAL/Util.cpp +++ b/libraries/AP_HAL/Util.cpp @@ -1,4 +1,4 @@ -#include +#include "AP_HAL.h" #include "Util.h" #include "utility/print_vprintf.h" diff --git a/libraries/AP_HAL/Util.h b/libraries/AP_HAL/Util.h index 1b7e0d3929..4c36123a7c 100644 --- a/libraries/AP_HAL/Util.h +++ b/libraries/AP_HAL/Util.h @@ -4,7 +4,7 @@ #include #include "AP_HAL_Namespace.h" -#include +#include class AP_HAL::Util { public: diff --git a/libraries/AP_HAL/examples/AnalogIn/AnalogIn.cpp b/libraries/AP_HAL/examples/AnalogIn/AnalogIn.cpp index 6566c47bbd..b421413b55 100644 --- a/libraries/AP_HAL/examples/AnalogIn/AnalogIn.cpp +++ b/libraries/AP_HAL/examples/AnalogIn/AnalogIn.cpp @@ -1,15 +1,15 @@ -#include -#include -#include -#include - -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include const AP_HAL::HAL& hal = AP_HAL_BOARD_DRIVER; diff --git a/libraries/AP_HAL/examples/Printf/Printf.cpp b/libraries/AP_HAL/examples/Printf/Printf.cpp index 6fcc80bcca..b642d0f301 100644 --- a/libraries/AP_HAL/examples/Printf/Printf.cpp +++ b/libraries/AP_HAL/examples/Printf/Printf.cpp @@ -1,35 +1,35 @@ -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include const AP_HAL::HAL& hal = AP_HAL_BOARD_DRIVER; diff --git a/libraries/AP_HAL/examples/RCInput/RCInput.cpp b/libraries/AP_HAL/examples/RCInput/RCInput.cpp index c52507dd99..4af3a5ab74 100644 --- a/libraries/AP_HAL/examples/RCInput/RCInput.cpp +++ b/libraries/AP_HAL/examples/RCInput/RCInput.cpp @@ -1,40 +1,40 @@ /* simple test of RC input interface */ -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include -#include -#include +#include +#include const AP_HAL::HAL& hal = AP_HAL_BOARD_DRIVER; diff --git a/libraries/AP_HAL/examples/RCInputToRCOutput/RCInputToRCOutput.cpp b/libraries/AP_HAL/examples/RCInputToRCOutput/RCInputToRCOutput.cpp index f5d652e67d..65d53adce5 100644 --- a/libraries/AP_HAL/examples/RCInputToRCOutput/RCInputToRCOutput.cpp +++ b/libraries/AP_HAL/examples/RCInputToRCOutput/RCInputToRCOutput.cpp @@ -4,40 +4,40 @@ Max update rate 10 Hz */ -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include -#include -#include +#include +#include const AP_HAL::HAL& hal = AP_HAL_BOARD_DRIVER; diff --git a/libraries/AP_HAL/examples/RCOutput/RCOutput.cpp b/libraries/AP_HAL/examples/RCOutput/RCOutput.cpp index 19ca0a5f68..2cb46c557c 100644 --- a/libraries/AP_HAL/examples/RCOutput/RCOutput.cpp +++ b/libraries/AP_HAL/examples/RCOutput/RCOutput.cpp @@ -1,40 +1,40 @@ /* simple test of RC output interface */ -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include -#include -#include +#include +#include const AP_HAL::HAL& hal = AP_HAL_BOARD_DRIVER; diff --git a/libraries/AP_HAL/examples/Storage/Storage.cpp b/libraries/AP_HAL/examples/Storage/Storage.cpp index e56eee15f1..331f39edf5 100644 --- a/libraries/AP_HAL/examples/Storage/Storage.cpp +++ b/libraries/AP_HAL/examples/Storage/Storage.cpp @@ -1,41 +1,41 @@ /* simple test of Storage API */ -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include -#include -#include -#include +#include +#include +#include #if HAL_OS_POSIX_IO #include diff --git a/libraries/AP_HAL/examples/UART_test/UART_test.cpp b/libraries/AP_HAL/examples/UART_test/UART_test.cpp index dd74cc3d33..fc38f07eea 100644 --- a/libraries/AP_HAL/examples/UART_test/UART_test.cpp +++ b/libraries/AP_HAL/examples/UART_test/UART_test.cpp @@ -1,40 +1,40 @@ /* simple test of UART interfaces */ -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include -#include -#include +#include +#include #if HAL_OS_POSIX_IO #include diff --git a/libraries/AP_HAL/utility/BetterStream.h b/libraries/AP_HAL/utility/BetterStream.h index e908f77942..bd2109ac5a 100644 --- a/libraries/AP_HAL/utility/BetterStream.h +++ b/libraries/AP_HAL/utility/BetterStream.h @@ -26,7 +26,7 @@ #include "Stream.h" /* prog_char_t: */ -#include +#include /* AP_HAL::BetterStream is a pure virtual interface. It resembles * Michael Smith's BetterStream library for Arduino. diff --git a/libraries/AP_HAL/utility/Print.cpp b/libraries/AP_HAL/utility/Print.cpp index 73c6171f4d..522e9c79d6 100644 --- a/libraries/AP_HAL/utility/Print.cpp +++ b/libraries/AP_HAL/utility/Print.cpp @@ -24,7 +24,7 @@ #include #include -#include +#include #include "../AP_HAL_Namespace.h" #include "Print.h" using namespace AP_HAL; diff --git a/libraries/AP_HAL/utility/Socket.cpp b/libraries/AP_HAL/utility/Socket.cpp index 5ecf2b6a04..40ba0b08b5 100644 --- a/libraries/AP_HAL/utility/Socket.cpp +++ b/libraries/AP_HAL/utility/Socket.cpp @@ -16,7 +16,7 @@ simple socket handling class for systems with BSD socket API */ -#include +#include #if HAL_OS_SOCKETS #include "Socket.h" diff --git a/libraries/AP_HAL/utility/Socket.h b/libraries/AP_HAL/utility/Socket.h index 96d74027be..adc298605b 100644 --- a/libraries/AP_HAL/utility/Socket.h +++ b/libraries/AP_HAL/utility/Socket.h @@ -19,7 +19,7 @@ #ifndef HAL_SOCKET_H #define HAL_SOCKET_H -#include +#include #if HAL_OS_SOCKETS #include diff --git a/libraries/AP_HAL/utility/ftoa_engine.cpp b/libraries/AP_HAL/utility/ftoa_engine.cpp index 21cba1ea20..954ebb85b0 100644 --- a/libraries/AP_HAL/utility/ftoa_engine.cpp +++ b/libraries/AP_HAL/utility/ftoa_engine.cpp @@ -28,8 +28,8 @@ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include -#include +#include +#include #include "ftoa_engine.h" #include diff --git a/libraries/AP_HAL/utility/ftoa_engine.h b/libraries/AP_HAL/utility/ftoa_engine.h index 456e578f6b..ba3c042b33 100644 --- a/libraries/AP_HAL/utility/ftoa_engine.h +++ b/libraries/AP_HAL/utility/ftoa_engine.h @@ -31,7 +31,7 @@ #ifndef _FTOA_ENGINE_H #define _FTOA_ENGINE_H -#include +#include #include int16_t ftoa_engine(float val, char *buf, diff --git a/libraries/AP_HAL/utility/print_vprintf.cpp b/libraries/AP_HAL/utility/print_vprintf.cpp index 44c81aa82f..8d9b09025d 100644 --- a/libraries/AP_HAL/utility/print_vprintf.cpp +++ b/libraries/AP_HAL/utility/print_vprintf.cpp @@ -38,8 +38,8 @@ /* $Id: vfprintf.c,v 1.18.2.1 2009/04/01 23:12:06 arcanum Exp $ */ -#include -#include +#include +#include #include #include #include diff --git a/libraries/AP_HAL/utility/print_vprintf.h b/libraries/AP_HAL/utility/print_vprintf.h index e0386a816f..ea7751f7d5 100644 --- a/libraries/AP_HAL/utility/print_vprintf.h +++ b/libraries/AP_HAL/utility/print_vprintf.h @@ -2,7 +2,7 @@ #ifndef __AP_HAL_UTILITY_VPRINTF_H__ #define __AP_HAL_UTILITY_VPRINTF_H__ -#include +#include #include void print_vprintf (AP_HAL::Print *s, unsigned char in_progmem, const char *fmt, va_list ap);