From 81e6d88560adfc7710d25aa308f91082f90e7b7d Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sat, 20 Jun 2015 15:00:57 +1000 Subject: [PATCH] StorageManager: fixed hang in erase() found by coverity --- libraries/StorageManager/StorageManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/StorageManager/StorageManager.cpp b/libraries/StorageManager/StorageManager.cpp index 60fcb0f8e7..f30ce14756 100644 --- a/libraries/StorageManager/StorageManager.cpp +++ b/libraries/StorageManager/StorageManager.cpp @@ -97,7 +97,7 @@ void StorageManager::erase(void) const StorageManager::StorageArea &area = StorageManager::layout[i]; uint16_t length = pgm_read_word(&area.length); uint16_t offset = pgm_read_word(&area.offset); - for (uint8_t ofs=0; length; ofs += sizeof(blk)) { + for (uint16_t ofs=0; ofs length) { n = length - ofs;