Browse Source

AP_Beacon: fix potential out-of-bounds write to beacon_state

uncovered by covarity and wickedshell
mission-4.1.18
Randy Mackay 8 years ago
parent
commit
9fc0bc19e7
  1. 4
      libraries/AP_Beacon/AP_Beacon_Backend.cpp

4
libraries/AP_Beacon/AP_Beacon_Backend.cpp

@ -38,7 +38,7 @@ void AP_Beacon_Backend::set_vehicle_position(const Vector3f& pos, float accuracy
void AP_Beacon_Backend::set_beacon_distance(uint8_t beacon_instance, float distance) void AP_Beacon_Backend::set_beacon_distance(uint8_t beacon_instance, float distance)
{ {
// sanity check instance // sanity check instance
if (beacon_instance > AP_BEACON_MAX_BEACONS) { if (beacon_instance >= AP_BEACON_MAX_BEACONS) {
return; return;
} }
@ -57,7 +57,7 @@ void AP_Beacon_Backend::set_beacon_distance(uint8_t beacon_instance, float dista
void AP_Beacon_Backend::set_beacon_position(uint8_t beacon_instance, const Vector3f& pos) void AP_Beacon_Backend::set_beacon_position(uint8_t beacon_instance, const Vector3f& pos)
{ {
// sanity check instance // sanity check instance
if (beacon_instance > AP_BEACON_MAX_BEACONS) { if (beacon_instance >= AP_BEACON_MAX_BEACONS) {
return; return;
} }

Loading…
Cancel
Save