From d73cd7d0e3b9f757b47eaf3720dd8113956fdf03 Mon Sep 17 00:00:00 2001 From: Peter Barker Date: Fri, 4 Mar 2022 14:29:46 +1100 Subject: [PATCH] AC_WPNav: stop libraries including AP_Logger.h in .h files AP_Logger.h is a nexus of includes; while this is being improved over time, there's no reason for the library headers to include AP_Logger.h as the logger itself is access by singleton and the structures are in LogStructure.h This necessitated moving The PID_Info structure out of AP_Logger's namespace. This cleans up a pretty nasty bit - that structure is definitely not simply used for logging, but also used to pass pid information around to controllers! There are a lot of patches in here because AP_Logger.h, acting as a nexus, was providing transitive header file inclusion in many (some unlikely!) places. --- libraries/AC_WPNav/AC_Circle.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libraries/AC_WPNav/AC_Circle.cpp b/libraries/AC_WPNav/AC_Circle.cpp index 1b6fd33d63..3da13dcef1 100644 --- a/libraries/AC_WPNav/AC_Circle.cpp +++ b/libraries/AC_WPNav/AC_Circle.cpp @@ -3,6 +3,8 @@ #include #include "AC_Circle.h" +#include + extern const AP_HAL::HAL& hal; const AP_Param::GroupInfo AC_Circle::var_info[] = {