Old behaviour is that anything that wasn't claimed (or failed to
allocate) would become a SITL RPM sensor. This meant we always had at
least one RPM sensor which was allocated but never provided valid data.
New behaviour is that if you want a SITL RPM sensor you have to set type
to 10.
This debug tool has been created to help users correctly impliment
and debug various RPM sensors when an oscilloscope is unavailable.
The RPM Sensor wiki will direct to this tool to help users.
AP_RPM: move PX4 IRQ handling into AP_HAL_PX4
AP_RPM: correct RPM sensor initialisation
The initialisation code used the type from the wrong configuration
parameters (if the first rpm sensor wasn't configured then the sensing
for the second sensor would use the type from the first).
The packing of drivers[...] was done in a non-sparse manner - i.e. if a
sensor wasn't detected then it would not take up space in the array.
The PX4 PWM backend relies on the instance number (offset in the drivers
array) corresponding to the parameters, so making this sparse is
required.
The main detection block fills in drivers based on the number of
instances detected so far, but the nullptr check checks based on the
number of detected backends. If the second instance wasn't configured we
wouldn't attempt to configure a third.
AP_RPM: add error reporting for attaching of interrupts
AP_RPM: use detach_interrupt method
AP_RPM: use (uint8_t)-1 in place of 255
See discussion here:
https://github.com/ArduPilot/ardupilot/issues/7331
we were getting some uninitialised variables. While it only showed up in
AP_SbusOut, it means we can't be sure it won't happen on other objects,
so safest to remove the approach
Thanks to assistance from Lucas, Peter and Francisco
Andrew Tridgell
Peter Barker
Randy Mackay
Henry Wurzburg
Gone4Dirt
bugobliterator
yaapu
Andy Piper
IamPete1
Tom Pittenger
Patrick José Pereira
LukeMike
Lucas De Marchi
Pierre Kancir