If anything in start_new_log did logging (for example, by sending a
statustext), we end up infinitely recursing.
With the patch:
diff --git a/libraries/AP_Logger/AP_Logger_File.cpp b/libraries/AP_Logger/AP_Logger_File.cpp
index 69b8ef0431..eb422d10f8 100644
--- a/libraries/AP_Logger/AP_Logger_File.cpp
+++ b/libraries/AP_Logger/AP_Logger_File.cpp
@@ -778,6 +778,7 @@ void AP_Logger_File::PrepForArming()
*/
void AP_Logger_File::start_new_log(void)
{
+ gcs().send_text(MAV_SEVERITY_WARNING, "Starting new log");
stop_logging();
start_new_log_reset_variables();
pbarker@bluebottle:~/rc/ardupilot(master)$
We see:
at ../../libraries/AP_Logger/AP_Logger_File.cpp:781
this=0x555555ad9d30, pBuffer=0x7fffff8209d0, size=75, is_critical=true)
at ../../libraries/AP_Logger/AP_Logger_Backend.cpp:372
this=0x555555ad9d30, pBuffer=0x7fffff8209d0, size=75)
at ../../libraries/AP_Logger/AP_Logger_Backend.h:32
this=0x555555ad9d30, message=0x7fffff820b10 "Starting new log")
at ../../libraries/AP_Logger/LogFile.cpp:466
this=0x555555a6d758 <copter+11384>,
message=0x7fffff820b10 "Starting new log")
at ../../libraries/AP_Logger/AP_Logger.cpp:752
this=0x555555a6e708 <copter+15400>, severity=MAV_SEVERITY_WARNING,
fmt=0x5555557d64d0 "Starting new log", arg_list=0x7fffff820be0,
dest_bitmask=1 '\001') at ../../libraries/GCS_MAVLink/GCS_Common.cpp:1847
this=0x555555a6e708 <copter+15400>, severity=MAV_SEVERITY_WARNING,
fmt=0x5555557d64d0 "Starting new log", arg_list=0x7fffff820be0)
at ../../libraries/GCS_MAVLink/GCS.cpp:53
this=0x555555a6e708 <copter+15400>, severity=MAV_SEVERITY_WARNING,
fmt=0x5555557d64d0 "Starting new log")
at ../../libraries/GCS_MAVLink/GCS.cpp:60
at ../../libraries/AP_Logger/AP_Logger_File.cpp:781
this=0x555555ad9d30, pBuffer=0x7fffff820dc0, size=75, is_critical=true)
at ../../libraries/AP_Logger/AP_Logger_Backend.cpp:372
I'm not aware of any instances in the code where this will actually
happen - but it could easily sneak in.
Legacy field types - do not use. These have been replaced by using the base C type and an appropriate multiplier column entry.
Char
CType+Mult
c
int16_t * 100
C
uint16_t * 100
e
int32_t * 100
E
uint32_t * 100
Units
All units here should be base units
This does mean battery capacity is here as "amp*second"
Please keep the names consistent with Tools/autotest/param_metadata/param.py:33
Char
Unit Abbrev.
Description
'-'
""
no units e.g. Pi
'?'
"UNKNOWN"
Units which haven't been worked out yet....
'A'
"A"
Ampere
'd'
"deg"
of the angular variety
'b'
"B"
bytes
'k'
"deg/s"
degrees per second. Degrees are NOT SI
'D'
"deglatitude"
degrees of latitude
'e'
"deg/s/s"
degrees per second per second. Degrees are NOT SI
'E'
"rad/s"
radians per second
'G'
"Gauss"
Gauss is not an SI unit
'h'
"degheading"
0.? to 359.?
'i'
"A.s"
Ampere second
'J'
"W.s"
Joule (Watt second)
'l'
"l"
litres
'L'
"rad/s/s"
radians per second per second
'm'
"m"
metres
'n'
"m/s"
metres per second
'N'
"N"
Newton
'o'
"m/s/s"
metres per second per second
'O'
"degC"
degrees Celsius. Not SI
'%'
"%"
percent
'S'
"satellites"
number of satellites
's'
"s"
seconds
'q'
"rpm"
rounds per minute. Not SI
'r'
"rad"
radians
'U'
"deglongitude"
degrees of longitude
'u'
"ppm"
pulses per minute
'v'
"V"
Volt
'P'
"Pa"
Pascal
'w'
"Ohm"
Ohm
'Y'
"us"
pulse width modulation in microseconds
'z'
"Hz"
Hertz
'#'
"instance"
(e.g.)Sensor instance number
Multipliers
This multiplier information applies to the raw value present in the
log. Any adjustment implied by the format field (e.g. the "centi"
in "centidegrees" is IGNORED for the purposes of scaling.
Essentially "format" simply tells you the C-type, and format-type h
(int16_t) is equivalent to format-type c (int16_t*100)
tl;dr a GCS shouldn't/mustn't infer any scaling from the unit name
Peter Barker
ca4af94833