diff --git a/CMakeLists.txt b/CMakeLists.txt index 83cd243145..e3515ca8bd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -77,6 +77,10 @@ # makes it clear to the user when variables are being set or targets # are being created. # +# * Setting a global variable in a CMakeLists.txt file is ok, because +# each CMakeLists.txt file has scope in the current directory and all +# subdirecties, so it is not truly global. +# # * All toolchain files should be included in the cmake # directory and named Toolchain-"name".cmake. # diff --git a/src/firmware/qurt/CMakeLists.txt b/src/firmware/qurt/CMakeLists.txt index dd5b09a39b..fb97327691 100644 --- a/src/firmware/qurt/CMakeLists.txt +++ b/src/firmware/qurt/CMakeLists.txt @@ -9,9 +9,8 @@ px4_qurt_generate_builtin_commands( OUT ${CMAKE_BINARY_DIR}/apps.h MODULE_LIST ${module_libraries}) -# FIXME @jgoppert - how to work around issues like this? -# Without changing global variables? # Clear -rdynamic flag which fails for hexagon +# this change is scoped in this directory and below set(CMAKE_SHARED_LIBRARY_LINK_C_FLAGS "") set(CMAKE_SHARED_LIBRARY_LINK_CXX_FLAGS "")