More config cleanup.

CMakeLists.txt

@@ -132,7 +132,7 @@ set(px4_required_config
 	config_module_list
 	)
 foreach(conf ${px4_required_config})
-	if(NOT DEFINED ${conf})
+	if(NOT DEFINED conf)
 		message(FATAL_ERROR "cmake/${config_module} must define ${conf}")
 	endif()
 endforeach()
@@ -160,14 +160,14 @@ list(GET config_args 2 LABEL)
 message(STATUS "TARGET: OS(${OS})-BOARD(${BOARD})-LABEL(${LABEL})")
 
 #=============================================================================
-# cmake modules
+# programs
 #
-enable_testing()
+find_package(PythonInterp REQUIRED)
 
 #=============================================================================
-# programs
+# cmake modules
 #
-find_package(PythonInterp REQUIRED)
+enable_testing()
 
 #=============================================================================
 # check required toolchain variables

Makefile

@@ -91,4 +91,8 @@ all: px4fmu-v2_default
 clean:
 	rm -rf build_*/
 
-.PHONY: clean
+# targets handled by cmake
+test: ;
+upload: ;
+
+.PHONY: clean test upload

cmake/nuttx/px4_impl_nuttx.cmake

@@ -86,10 +86,10 @@ function(px4_nuttx_add_firmware)
 	#TODO handle param_xml
 	if(PARAM_XML)
 		add_custom_command(OUTPUT ${OUT}
-			COMMAND ${process_params}
+			COMMAND ${PYTHON_EXECUTABLE} ${process_params}
 				--src-path ${CMAKE_SOURCE_DIR}/src
 				--board CONFIG_ARCH_BOARD_${BOARD} --xml
-			COMMAND ${process_airframes}
+			COMMAND ${PYTHON_EXECUTABLE} ${process_airframes}
 				-a ${CMAKE_SOURCE_DIR}/ROMFS/px4fmu_common/init.d
 				--board CONFIG_ARCH_BOARD_${BOARD} --xml
 			COMMAND ${OBJCOPY} -O binary ${EXE} ${EXE}.bin
@@ -97,10 +97,9 @@ function(px4_nuttx_add_firmware)
 				--prototype ${CMAKE_SOURCE_DIR}/Images/${BOARD}.prototype
 				--git_identity ${CMAKE_SOURCE_DIR}
 				--parameter_xml parameters.xml
-				--airframe_xml airframe.xml
+				--airframe_xml airframes.xml
 				--image ${EXE}.bin > ${OUT}
 			DEPENDS ${EXE}
-			WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
 			)
 	else()
 		add_custom_command(OUTPUT ${OUT}
@@ -110,7 +109,6 @@ function(px4_nuttx_add_firmware)
 				--git_identity ${CMAKE_SOURCE_DIR}
 				--image ${EXE}.bin > ${OUT}
 			DEPENDS ${EXE}
-			WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
 			)
 	endif()
 endfunction()