zrzk
/
px4_autopilot
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Browse Source

Fix -Werror=stringop-overflow on gcc 7 

The error was:
Firmware/src/systemcmds/hardfault_log/hardfault_log.c:312:7: error: specified bound 30 equals the size of the destination [-Werror=stringop-overflow=]
       strncat(marker, sp_name, sizeof(marker));
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sbg
Julien Lecoeur 8 years ago committed by Beat Küng
parent
abcb920df4
commit
61d6903b40
1 changed files with 3 additions and 3 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 6
      src/systemcmds/hardfault_log/hardfault_log.c

6
src/systemcmds/hardfault_log/hardfault_log.c
Unescape View File

@ -311,16 +311,16 @@ static int write_stack(bool inValid, int winsize, uint32_t wtopaddr,
for (int i = 0; i < chunk; i++) { for (int i = 0; i < chunk; i++) {
if (wtopaddr == topaddr) { if (wtopaddr == topaddr) {
strncpy(marker, "<-- ", sizeof(marker)); strncpy(marker, "<-- ", sizeof(marker));
strncat(marker, sp_name, sizeof(marker)); strncat(marker, sp_name, sizeof(marker) - 1);
strncat(marker, " top", sizeof(marker)); strncat(marker, " top", sizeof(marker));
} else if (wtopaddr == spaddr) { } else if (wtopaddr == spaddr) {
strncpy(marker, "<-- ", sizeof(marker)); strncpy(marker, "<-- ", sizeof(marker));
strncat(marker, sp_name, sizeof(marker)); strncat(marker, sp_name, sizeof(marker) - 1);
} else if (wtopaddr == botaddr) { } else if (wtopaddr == botaddr) {
strncpy(marker, "<-- ", sizeof(marker)); strncpy(marker, "<-- ", sizeof(marker));
strncat(marker, sp_name, sizeof(marker)); strncat(marker, sp_name, sizeof(marker) - 1);
strncat(marker, " bottom", sizeof(marker)); strncat(marker, " bottom", sizeof(marker));
} else { } else {

Write Preview
Loading…
Cancel
Save