From 90f4e77a80f16e679cf665deee4359337d44a970 Mon Sep 17 00:00:00 2001
From: Daniel Agar <daniel@agar.ca>
Date: Sat, 4 Aug 2018 12:51:51 -0400
Subject: [PATCH] Jenkinsfile add new Analysis stage (#10150)

---
 Jenkinsfile | 114 +++++++++++++++++++++++++++-------------------------
 1 file changed, 60 insertions(+), 54 deletions(-)

diff --git a/Jenkinsfile b/Jenkinsfile
index 8eae271d96..e087c44734 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -2,7 +2,8 @@ pipeline {
   agent none
   stages {
 
-    stage('Test') {
+ stage('Analysis') {
+
       parallel {
 
         stage('Style Check') {
@@ -96,23 +97,22 @@ pipeline {
           }
         }
 
-        stage('tests') {
+        stage('check stack') {
           agent {
             docker {
-              image 'px4io/px4-dev-base:2018-07-19'
+              image 'px4io/px4-dev-nuttx:2018-07-19'
               args '-e CCACHE_BASEDIR=$WORKSPACE -v ${CCACHE_DIR}:${CCACHE_DIR}:rw'
             }
           }
           steps {
             sh 'export'
             sh 'make distclean'
-            sh 'make posix_sitl_default test_results_junit'
-            junit 'build/posix_sitl_default/JUnitTestResults.xml'
+            sh 'make px4fmu-v2_default stack_check'
             sh 'make distclean'
           }
         }
 
-        stage('test mission (code coverage)') {
+        stage('code coverage (mission test)') {
           agent {
             docker {
               image 'px4io/px4-dev-ros:2018-07-19'
@@ -122,7 +122,7 @@ pipeline {
           steps {
             sh 'export'
             sh 'make distclean; rm -rf .ros; rm -rf .gazebo'
-            sh 'make tests_mission_coverage'
+            sh 'ulimit -c unlimited; make tests_mission_coverage'
             withCredentials([string(credentialsId: 'FIRMWARE_CODECOV_TOKEN', variable: 'CODECOV_TOKEN')]) {
               sh 'curl -s https://codecov.io/bash | bash -s'
             }
@@ -130,8 +130,55 @@ pipeline {
           }
         }
 
+        stage('code coverage (unit tests)') {
+          agent {
+            docker {
+              image 'px4io/px4-dev-base:2018-07-19'
+              args '-e CCACHE_BASEDIR=$WORKSPACE -v ${CCACHE_DIR}:${CCACHE_DIR}:rw'
+            }
+          }
+          steps {
+            sh 'export'
+            sh 'make distclean'
+            sh 'ulimit -c unlimited; make tests_coverage'
+            withCredentials([string(credentialsId: 'FIRMWARE_CODECOV_TOKEN', variable: 'CODECOV_TOKEN')]) {
+              sh 'curl -s https://codecov.io/bash | bash -s'
+            }
+            sh 'make distclean'
+          }
+          post {
+            failure {
+              sh('ls -a')
+              sh('find . -name core')
+              sh('gdb --batch --quiet -ex "thread apply all bt full" -ex "quit" build/posix_sitl_default/px4 core')
+            }
+          }
+        }
+
+      } // parallel
+    } // stage Analysis
+
+    stage('Test') {
+      parallel {
+
+        stage('unit tests') {
+          agent {
+            docker {
+              image 'px4io/px4-dev-base:2018-07-19'
+              args '-e CCACHE_BASEDIR=$WORKSPACE -v ${CCACHE_DIR}:${CCACHE_DIR}:rw'
+            }
+          }
+          steps {
+            sh 'export'
+            sh 'make distclean'
+            sh 'make posix_sitl_default test_results_junit'
+            junit 'build/posix_sitl_default/JUnitTestResults.xml'
+            sh 'make distclean'
+          }
+        }
+
         // TODO: PX4 requires clean shutdown first
-        // stage('tests (address sanitizer)') {
+        // stage('unit tests (address sanitizer)') {
         //   agent {
         //     docker {
         //       image 'px4io/px4-dev-base:2018-07-19'
@@ -150,50 +197,8 @@ pipeline {
         //   }
         // }
 
-        // TODO: test and re-enable once GDB is available in px4-dev-ros
-        // stage('tests (code coverage)') {
-        //   agent {
-        //     docker {
-        //       image 'px4io/px4-dev-ros:2018-07-19'
-        //       args '-e CCACHE_BASEDIR=$WORKSPACE -v ${CCACHE_DIR}:${CCACHE_DIR}:rw'
-        //     }
-        //   }
-        //   steps {
-        //     sh 'export'
-        //     sh 'make distclean'
-        //     sh 'ulimit -c unlimited; make tests_coverage'
-        //     sh 'ls'
-        //     withCredentials([string(credentialsId: 'FIRMWARE_CODECOV_TOKEN', variable: 'CODECOV_TOKEN')]) {
-        //       sh 'curl -s https://codecov.io/bash | bash -s'
-        //     }
-        //     sh 'make distclean'
-        //   }
-        //   post {
-        //     failure {
-        //       sh('find . -name core')
-        //       sh('gdb --batch --quiet -ex "thread apply all bt full" -ex "quit" build/posix_sitl_default/px4 core')
-        //     }
-        //   }
-        // }
-
-        stage('check stack') {
-          agent {
-            docker {
-              image 'px4io/px4-dev-nuttx:2018-07-19'
-              args '-e CCACHE_BASEDIR=$WORKSPACE -v ${CCACHE_DIR}:${CCACHE_DIR}:rw'
-            }
-          }
-          steps {
-            sh 'export'
-            sh 'make distclean'
-            sh 'make px4fmu-v2_default stack_check'
-            sh 'make distclean'
-          }
-        }
-
-
-      }
-    }
+      } // parallel
+    } // stage Test
 
     stage('Generate Metadata') {
 
@@ -250,8 +255,9 @@ pipeline {
             sh 'make distclean'
           }
         }
-      }
-    }
+
+      } // parallel
+    } // stage: Generate Metadata
 
   } // stages