From 9fb98dad3e8b8da68e223b78f7191022c2a7cea7 Mon Sep 17 00:00:00 2001 From: Julien Lecoeur Date: Tue, 5 Dec 2017 20:41:23 +0100 Subject: [PATCH] Fix warning -Wimplicit-fallthrough --- src/drivers/lis3mdl/lis3mdl_i2c.cpp | 2 ++ src/drivers/mpu6000/mpu6000_spi.cpp | 2 ++ src/drivers/mpu9250/mpu9250_spi.cpp | 2 ++ src/drivers/protocol_splitter/protocol_splitter.cpp | 5 +++-- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/drivers/lis3mdl/lis3mdl_i2c.cpp b/src/drivers/lis3mdl/lis3mdl_i2c.cpp index 388bd5666f..5215d52960 100644 --- a/src/drivers/lis3mdl/lis3mdl_i2c.cpp +++ b/src/drivers/lis3mdl/lis3mdl_i2c.cpp @@ -114,6 +114,8 @@ LIS3MDL_I2C::ioctl(unsigned operation, unsigned &arg) case MAGIOCGEXTERNAL: external(); + /* FALLTHROUGH */ + case DEVIOCGDEVICEID: return CDev::ioctl(nullptr, operation, arg); diff --git a/src/drivers/mpu6000/mpu6000_spi.cpp b/src/drivers/mpu6000/mpu6000_spi.cpp index 99a70a2d8f..acf747f342 100644 --- a/src/drivers/mpu6000/mpu6000_spi.cpp +++ b/src/drivers/mpu6000/mpu6000_spi.cpp @@ -242,6 +242,8 @@ MPU6000_SPI::ioctl(unsigned operation, unsigned &arg) case ACCELIOCGEXTERNAL: external(); + /* FALLTHROUGH */ + case DEVIOCGDEVICEID: return CDev::ioctl(nullptr, operation, arg); diff --git a/src/drivers/mpu9250/mpu9250_spi.cpp b/src/drivers/mpu9250/mpu9250_spi.cpp index b8c7b6e2c5..c880231c16 100644 --- a/src/drivers/mpu9250/mpu9250_spi.cpp +++ b/src/drivers/mpu9250/mpu9250_spi.cpp @@ -170,6 +170,8 @@ MPU9250_SPI::ioctl(unsigned operation, unsigned &arg) case ACCELIOCGEXTERNAL: external(); + /* FALLTHROUGH */ + case DEVIOCGDEVICEID: return CDev::ioctl(nullptr, operation, arg); diff --git a/src/drivers/protocol_splitter/protocol_splitter.cpp b/src/drivers/protocol_splitter/protocol_splitter.cpp index d0f6d8252f..0b906959ea 100644 --- a/src/drivers/protocol_splitter/protocol_splitter.cpp +++ b/src/drivers/protocol_splitter/protocol_splitter.cpp @@ -379,7 +379,8 @@ ssize_t Mavlink2Dev::write(struct file *filp, const char *buffer, size_t buflen) return 0; } - //no break + /* FALLTHROUGH */ + case ParserState::GotLength: { _packet_len -= buflen; int buf_free; @@ -509,8 +510,8 @@ ssize_t RtpsDev::write(struct file *filp, const char *buffer, size_t buflen) _parser_state = ParserState::GotLength; lock(Write); + /* FALLTHROUGH */ - //no break case ParserState::GotLength: { _packet_len -= buflen; int buf_free;