Browse Source

clang-tidy: enable hicpp-braces-around-statements and fix

sbg
Daniel Agar 5 years ago
parent
commit
a7f330075a
  1. 1
      .clang-tidy
  2. 2
      platforms/common/work_queue/queue.c
  3. 2
      src/modules/logger/logger.cpp
  4. 2
      src/modules/mavlink/mavlink_ftp.cpp
  5. 2
      src/modules/mavlink/mavlink_parameters.cpp

1
.clang-tidy

@ -48,7 +48,6 @@ Checks: '*, @@ -48,7 +48,6 @@ Checks: '*,
-google-readability-todo,
-google-runtime-int,
-google-runtime-references,
-hicpp-braces-around-statements,
-hicpp-deprecated-headers,
-hicpp-explicit-conversions,
-hicpp-function-size,

2
platforms/common/work_queue/queue.c

@ -55,7 +55,7 @@ void sq_rem(sq_entry_t *node, sq_queue_t *queue) @@ -55,7 +55,7 @@ void sq_rem(sq_entry_t *node, sq_queue_t *queue)
for (prev = (sq_entry_t *)queue->head;
prev && prev->flink != node;
prev = prev->flink);
prev = prev->flink) {}
if (prev) {
sq_remafter(prev, queue);

2
src/modules/logger/logger.cpp

@ -1152,7 +1152,7 @@ void Logger::run() @@ -1152,7 +1152,7 @@ void Logger::run()
* And on linux this is quite accurate as well, but under NuttX it is not accurate,
* because usleep() has only a granularity of CONFIG_MSEC_PER_TICK (=1ms).
*/
while (px4_sem_wait(&timer_callback_data.semaphore) != 0);
while (px4_sem_wait(&timer_callback_data.semaphore) != 0) {}
}
}

2
src/modules/mavlink/mavlink_ftp.cpp

@ -364,7 +364,7 @@ MavlinkFTP::_workList(PayloadHeader *payload, bool list_hidden) @@ -364,7 +364,7 @@ MavlinkFTP::_workList(PayloadHeader *payload, bool list_hidden)
// move to the requested offset
int requested_offset = payload->offset;
while (requested_offset-- > 0 && readdir(dp));
while (requested_offset-- > 0 && readdir(dp)) {}
for (;;) {
errno = 0;

2
src/modules/mavlink/mavlink_parameters.cpp

@ -289,7 +289,7 @@ MavlinkParametersManager::send(const hrt_abstime t) @@ -289,7 +289,7 @@ MavlinkParametersManager::send(const hrt_abstime t)
int i = 0;
// Send while burst is not exceeded, we still have buffer space and still something to send
while ((i++ < max_num_to_send) && (_mavlink->get_free_tx_buf() >= get_size()) && send_params());
while ((i++ < max_num_to_send) && (_mavlink->get_free_tx_buf() >= get_size()) && send_params()) {}
}
bool

Loading…
Cancel
Save