From b068c6178455bdf1fd04ad52a33496040f4f9d0d Mon Sep 17 00:00:00 2001
From: Daniel Agar <daniel@agar.ca>
Date: Tue, 31 Jan 2017 14:38:01 -0500
Subject: [PATCH] clang-tidy clang-analyzer-core.NonNullParamChecker

---
 .clang-tidy                                 | 8 ++++----
 src/modules/mavlink/mavlink_log_handler.cpp | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index 3f78ec7514..3247d7b6a2 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -22,7 +22,7 @@ Checks:          'clang-diagnostic-*,clang-analyzer-*,-*,
 		## TODO: fix code and enable # clang-analyzer-core.CallAndMessage,
 		clang-analyzer-core.DivideZero,
 		clang-analyzer-core.DynamicTypePropagation,
-		## TODO: fix code and enable # clang-analyzer-core.NonNullParamChecker,
+		clang-analyzer-core.NonNullParamChecker,
 		## TODO: fix code and enable # clang-analyzer-core.NullDereference,
 		clang-analyzer-core.StackAddressEscape,
 		#clang-analyzer-core.UndefinedBinaryOperatorResult,
@@ -41,7 +41,7 @@ Checks:          'clang-diagnostic-*,clang-analyzer-*,-*,
 		clang-analyzer-nullability.NullablePassedToNonnull,
 		clang-analyzer-nullability.NullableReturnedFromNonnull,
 		clang-analyzer-nullability.NullPassedToNonnull,
-		## TODO: fix code and enable # clang-analyzer-nullability.NullReturnedFromNonnull,
+		clang-analyzer-nullability.NullReturnedFromNonnull,
 		## evaluate # clang-analyzer-optin.cplusplus.VirtualCall,
 		## TODO: fix code and enable #  clang-analyzer-optin.performance.Padding,
 		## TODO: fix code and enable # clang-analyzer-security.FloatLoopCounter,
@@ -64,14 +64,14 @@ Checks:          'clang-diagnostic-*,clang-analyzer-*,-*,
 		cppcoreguidelines-c-copy-assignment-signature,
 		#cppcoreguidelines-interfaces-global-init,
 		#cppcoreguidelines-no-malloc,
-		## TODO: fix code and enable # cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+		#cppcoreguidelines-pro-bounds-array-to-pointer-decay,
 		#cppcoreguidelines-pro-bounds-constant-array-index,
 		#cppcoreguidelines-pro-bounds-pointer-arithmetic,
 		## TODO: fix code and enable # cppcoreguidelines-pro-type-const-cast,
 		#cppcoreguidelines-pro-type-cstyle-cast,
 		## TODO: fix code and enable # cppcoreguidelines-pro-type-member-init,
 		#cppcoreguidelines-pro-type-reinterpret-cast,
-		## TODO: fix code and enable # cppcoreguidelines-pro-type-static-cast-downcast,
+		cppcoreguidelines-pro-type-static-cast-downcast,
 		#cppcoreguidelines-pro-type-union-access,
 		#cppcoreguidelines-pro-type-vararg,
 		cppcoreguidelines-slicing,
diff --git a/src/modules/mavlink/mavlink_log_handler.cpp b/src/modules/mavlink/mavlink_log_handler.cpp
index fe1d785bcf..a5d331fca1 100644
--- a/src/modules/mavlink/mavlink_log_handler.cpp
+++ b/src/modules/mavlink/mavlink_log_handler.cpp
@@ -579,9 +579,9 @@ LogListHelper::_scan_logs(FILE *f, const char *dir, time_t &date)
 				}
 			}
 		}
-	}
 
-	closedir(dp);
+		closedir(dp);
+	}
 }
 
 //-------------------------------------------------------------------