Browse Source

addressed review comments (fixes in error message and comments)

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
release/1.12
Silvan Fuhrer 4 years ago
parent
commit
bf311ed77d
  1. 4
      src/modules/fw_att_control/FixedwingAttitudeControl.cpp
  2. 2
      src/modules/fw_pos_control_l1/FixedwingPositionControl.cpp

4
src/modules/fw_att_control/FixedwingAttitudeControl.cpp

@ -242,7 +242,7 @@ float FixedwingAttitudeControl::get_airspeed_and_update_scaling() @@ -242,7 +242,7 @@ float FixedwingAttitudeControl::get_airspeed_and_update_scaling()
} else {
// VTOL: if we have no airspeed available and we are in hover mode then assume the lowest airspeed possible
// this assumption is good as long as the vehicle is not hovering in a headwind which is much larger
// than the minimum airspeed
// than the stall airspeed
if (_vehicle_status.is_vtol && _vehicle_status.vehicle_type == vehicle_status_s::VEHICLE_TYPE_ROTARY_WING
&& !_vehicle_status.in_transition_mode) {
airspeed = _param_fw_airspd_stall.get();
@ -250,7 +250,7 @@ float FixedwingAttitudeControl::get_airspeed_and_update_scaling() @@ -250,7 +250,7 @@ float FixedwingAttitudeControl::get_airspeed_and_update_scaling()
}
/*
* For scaling our actuators using anything less than the min (close to stall)
* For scaling our actuators using anything less than the stall
* speed doesn't make any sense - its the strongest reasonable deflection we
* want to do in flight and its the baseline a human pilot would choose.
*

2
src/modules/fw_pos_control_l1/FixedwingPositionControl.cpp

@ -145,7 +145,7 @@ FixedwingPositionControl::parameters_update() @@ -145,7 +145,7 @@ FixedwingPositionControl::parameters_update()
// sanity check parameters
if (_param_fw_airspd_max.get() < _param_fw_airspd_min.get()) {
mavlink_log_critical(&_mavlink_log_pub, "Config invalid: Airspeed min smaller than max");
mavlink_log_critical(&_mavlink_log_pub, "Config invalid: Airspeed max smaller than min");
check_ret = PX4_ERROR;
}

Loading…
Cancel
Save