From bff93685a50e58964743857e671ff35d36f3ca4a Mon Sep 17 00:00:00 2001 From: Matthias Grob Date: Thu, 16 May 2019 09:43:34 +0200 Subject: [PATCH] pull_request_template: order and phrasing Since I reorder the points every time I open a pull request I thought I might as well propose this order for the template. --- PULL_REQUEST_TEMPLATE.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 3e1fa64b84..9a32d9f52c 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,10 +1,10 @@ -Please use [PX4 Discuss](http://discuss.px4.io/) or [Slack](http://slack.px4.io/) to align on pull requests if necessary. - -**Test data / coverage** -Logs uploaded to http://logs.px4.io or screenshots. +Please use [PX4 Discuss](http://discuss.px4.io/) or [Slack](http://slack.px4.io/) to align on pull requests if necessary. You can then open draft pull requests to get early feedback. **Describe problem solved by the proposed pull request** -A clear and concise description of the problem, if any, this feature will solve. E.g. I'm always frustrated when ... +A clear and concise description of the problem this proposed change will solve. E.g. For this use case I ran into... + +**Test data / coverage** +How was it tested? What cases were covered? Logs uploaded to https://review.px4.io/ and screenshots of the important plot parts. **Describe your preferred solution** A clear and concise description of what you have implemented. @@ -13,4 +13,4 @@ A clear and concise description of what you have implemented. A clear and concise description of alternative solutions or features you've considered. **Additional context** -Add any other context or screenshots for the feature request here. +Add any other related context or media.