From e79fa1773d404686d0b306662036475cfd62c8bf Mon Sep 17 00:00:00 2001
From: mcsauder <mcsauder@gmail.com>
Date: Tue, 31 Jul 2018 11:17:09 -0600
Subject: [PATCH] Alphabetize vehicle type logic block order and Update param
 set MAV_TYPE  logic to only set the parameter if no MAV_TYPE was previously
 set.

---
 ROMFS/px4fmu_common/init.d/rc.vehicle_setup | 91 ++++++++++-----------
 1 file changed, 42 insertions(+), 49 deletions(-)

diff --git a/ROMFS/px4fmu_common/init.d/rc.vehicle_setup b/ROMFS/px4fmu_common/init.d/rc.vehicle_setup
index 54f3a8da1b..4ca1e26f47 100644
--- a/ROMFS/px4fmu_common/init.d/rc.vehicle_setup
+++ b/ROMFS/px4fmu_common/init.d/rc.vehicle_setup
@@ -18,16 +18,17 @@ then
 
 	if [ $MAV_TYPE == none ]
 	then
-		# Use MAV_TYPE = 1 (fixed wing) if not defined.
+		# Set a default MAV_TYPE = 1 if not defined.
 		set MAV_TYPE 1
 	fi
 
+	# Set the mav type parameter.
 	param set MAV_TYPE ${MAV_TYPE}
 
-	# Load mixer and configure outputs
+	# Load mixer and configure outputs.
 	sh /etc/init.d/rc.interface
 
-	# Start standard fixedwing apps
+	# Start standard fixedwing apps.
 	sh /etc/init.d/rc.fw_apps
 fi
 
@@ -38,11 +39,14 @@ if [ $VEHICLE_TYPE == mc ]
 then
 	if [ $MIXER == none ]
 	then
-		echo "Mixer undefined"
+		echo "MC mixer undefined"
 	fi
 
 	if [ $MAV_TYPE == none ]
 	then
+		# Set a default MAV_TYPE = 2 if not defined.
+		set MAV_TYPE 2
+
 		# Use mixer to detect vehicle type
 		if [ $MIXER == quad_x -o $MIXER == quad_+ ]
 		then
@@ -56,9 +60,9 @@ then
 		then
 			set MAV_TYPE 2
 		fi
-		if [ $MIXER == tri_y_yaw- -o $MIXER == tri_y_yaw+ ]
+		if [ $MIXER == coax ]
 		then
-			set MAV_TYPE 15
+			set MAV_TYPE 3
 		fi
 		if [ $MIXER == hexa_x -o $MIXER == hexa_+ ]
 		then
@@ -76,19 +80,14 @@ then
 		then
 			set MAV_TYPE 14
 		fi
-		if [ $MIXER == coax ]
+		if [ $MIXER == tri_y_yaw- -o $MIXER == tri_y_yaw+ ]
 		then
-			set MAV_TYPE 3
+			set MAV_TYPE 15
 		fi
 	fi
 
-	# Still no MAV_TYPE found.
-	if [ $MAV_TYPE == none ]
-	then
-		param set MAV_TYPE 2
-	else
-		param set MAV_TYPE ${MAV_TYPE}
-	fi
+	# Set the mav type parameter.
+	param set MAV_TYPE ${MAV_TYPE}
 
 	# Load mixer and configure outputs.
 	sh /etc/init.d/rc.interface
@@ -98,72 +97,66 @@ then
 fi
 
 #
-# VTOL setup.
+# UGV setup.
 #
-if [ $VEHICLE_TYPE == vtol ]
+if [ $VEHICLE_TYPE == ugv ]
 then
 	if [ $MIXER == none ]
 	then
-		echo "VTOL mixer undefined"
+		# Set default mixer for UGV if not defined.
+		set MIXER ugv_generic
 	fi
 
 	if [ $MAV_TYPE == none ]
 	then
-		# Use mixer to detect vehicle type.
-		if [ $MIXER == caipirinha_vtol ]
-		then
-			set MAV_TYPE 19
-		fi
-		if [ $MIXER == firefly6 ]
-		then
-			set MAV_TYPE 21
-		fi
-		if [ $MIXER == quad_x_pusher_vtol ]
-		then
-			set MAV_TYPE 22
-		fi
+		# Set a default MAV_TYPE = 10 if not defined.
+		set MAV_TYPE 10
 	fi
 
-	# Still no MAV_TYPE found.
-	if [ $MAV_TYPE == none ]
-	then
-		echo "Unknown MAV_TYPE"
-		param set MAV_TYPE 19
-	else
-		param set MAV_TYPE ${MAV_TYPE}
-	fi
+	# Set the mav type parameter.
+	param set MAV_TYPE ${MAV_TYPE}
 
 	# Load mixer and configure outputs.
 	sh /etc/init.d/rc.interface
 
-	# Start standard vtol apps.
-	sh /etc/init.d/rc.vtol_apps
+	# Start standard UGV apps.
+	sh /etc/init.d/rc.ugv_apps
 fi
 
 #
-# UGV setup
+# VTOL setup.
 #
-if [ $VEHICLE_TYPE == ugv ]
+if [ $VEHICLE_TYPE == vtol ]
 then
 	if [ $MIXER == none ]
 	then
-		# Set default mixer for UGV if not defined.
-		set MIXER ugv_generic
+		echo "VTOL mixer undefined"
 	fi
 
 	if [ $MAV_TYPE == none ]
 	then
-		# Use MAV_TYPE = 10 (UGV) if not defined.
-		set MAV_TYPE 10
+		# Set a default MAV_TYPE = 19 if not defined.
+		set MAV_TYPE 19
+
+		# Use mixer to detect vehicle type.
+		if [ $MIXER == firefly6 ]
+		then
+			set MAV_TYPE 21
+		fi
+		if [ $MIXER == quad_x_pusher_vtol ]
+		then
+			set MAV_TYPE 22
+		fi
 	fi
 
+	# Set the mav type parameter.
 	param set MAV_TYPE ${MAV_TYPE}
 
 	# Load mixer and configure outputs.
 	sh /etc/init.d/rc.interface
 
-	# Start standard UGV apps.
-	sh /etc/init.d/rc.ugv_apps
+	# Start standard vtol apps.
+	sh /etc/init.d/rc.vtol_apps
 fi
 
 #