From fd261b590cdf8454837cc9843722e4a85750da3a Mon Sep 17 00:00:00 2001 From: Julian Oes Date: Mon, 7 Dec 2020 14:59:10 +1300 Subject: [PATCH] battery: don't init uint16_t with -1.0f This was flagged as undefined behaviour by fuzz testing. --- src/lib/battery/battery.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/battery/battery.cpp b/src/lib/battery/battery.cpp index bb1c3dec6a..9012aad797 100644 --- a/src/lib/battery/battery.cpp +++ b/src/lib/battery/battery.cpp @@ -113,7 +113,7 @@ void Battery::reset() // TODO: check if it is sane to reset warning to NONE _battery_status.warning = battery_status_s::BATTERY_WARNING_NONE; _battery_status.connected = false; - _battery_status.capacity = _params.capacity; + _battery_status.capacity = _params.capacity > 0.0f ? (uint16_t)_params.capacity : 0; _battery_status.temperature = NAN; _battery_status.id = (uint8_t) _index; }