Browse Source

autotest: remove pointless fetch_parameters call

And the entire method, replace with equivalent test
c415-sdk
Peter Barker 4 years ago committed by Peter Barker
parent
commit
0daa1a63d3
  1. 6
      Tools/autotest/common.py
  2. 8
      Tools/autotest/rover.py

6
Tools/autotest/common.py

@ -1511,10 +1511,6 @@ class AutoTest(ABC):
locs locs
]) ])
def fetch_parameters(self):
self.mavproxy.send("param fetch\n")
self.mavproxy.expect("Received [0-9]+ parameters")
def send_reboot_command(self): def send_reboot_command(self):
self.mav.mav.command_long_send(self.sysid_thismav(), self.mav.mav.command_long_send(self.sysid_thismav(),
1, 1,
@ -8575,7 +8571,6 @@ switch value'''
self.mavproxy.expect("sitl_accelcal: attitude detected, please press any key..", timeout=timeout) self.mavproxy.expect("sitl_accelcal: attitude detected, please press any key..", timeout=timeout)
self.mavproxy.send("\n") self.mavproxy.send("\n")
self.mavproxy.expect("APM: Calibration successful", timeout=timeout) self.mavproxy.expect("APM: Calibration successful", timeout=timeout)
self.fetch_parameters()
self.drain_mav() self.drain_mav()
self.progress("Checking results") self.progress("Checking results")
@ -8634,7 +8629,6 @@ switch value'''
mavutil.mavlink.MAV_CMD_PREFLIGHT_CALIBRATION, 0, mavutil.mavlink.MAV_CMD_PREFLIGHT_CALIBRATION, 0,
0, 0, 0, 0, 2, 0, 0) 0, 0, 0, 0, 2, 0, 0)
self.wait_statustext('Trim OK') self.wait_statustext('Trim OK')
self.fetch_parameters()
self.drain_mav() self.drain_mav()
self.progress("Checking results") self.progress("Checking results")

8
Tools/autotest/rover.py

@ -5661,6 +5661,10 @@ Brakes have negligible effect (with=%0.2fm without=%0.2fm delta=%0.2fm)
if ex is not None: if ex is not None:
raise ex raise ex
def test_mavproxy_param(self):
self.mavproxy.send("param fetch\n")
self.mavproxy.expect("Received [0-9]+ parameters")
def tests(self): def tests(self):
'''return list of all tests''' '''return list of all tests'''
ret = super(AutoTestRover, self).tests() ret = super(AutoTestRover, self).tests()
@ -5775,6 +5779,10 @@ Brakes have negligible effect (with=%0.2fm without=%0.2fm delta=%0.2fm)
"Test Offboard Control", "Test Offboard Control",
self.test_offboard), self.test_offboard),
("MAVProxyParam",
"Test MAVProxy parameter handling",
self.test_mavproxy_param),
("GCSFence", ("GCSFence",
"Upload and download of fence", "Upload and download of fence",
self.test_gcs_fence), self.test_gcs_fence),

Loading…
Cancel
Save